MongoDB Backups #1322
Closed
MongoDB Backups #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectly enable db backups by default
… is set, also allow customizing db_backups.schedule and db_backups.path
tw4l
approved these changes
Oct 31, 2023
| # daily under /db-backups | ||
| db_backup: | ||
| #storage: "default" | ||
| #schedule: "26 0 * * *" |
There was a problem hiding this comment.
Interesting choice of time but why not :)
|
Should figure out encryption prior to merging/deploying this, so that we don't have an unencrypted copy of our database in an S3 bucket. |
tw4l
requested changes
Nov 1, 2023
|
Probably the best option here is to make this optional by requiring the dump to be encrypted with openssl, by providing an optional private key for encryption. or, can also provide the name of designated secret that can be managed externally (but requires more setup). |
|
Closing this for now, as its fairly low priority after 11 months, and can possibly be implemented outside Browsertrix itself. If using an externally managed MongoDB as we do, it may have its own backups, so this is less of a priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CronJob which can be enabled via values, using one of the defined storages.
Backups run daily (by default) and store output of
mongodump ... --archiveto a timestamped file.