Skip to content

Conversation

@niatalwalkar
Copy link
Contributor

@niatalwalkar niatalwalkar commented Nov 30, 2025

Description

Related Issue: #5377.

This PR updates the local Link component so that aria-current="page" is set based on the full URL.

Steps for reproduction

  1. Previously, links such as /path?tag=bla were not marked as current.
  2. Now, if the full URL (path + query params) matches, the link gets aria-current="page".

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof
Copy link
Member

kof commented Dec 3, 2025

@TrySound do you know why react router isn't doing it that way? looks like by doing this we are fixing react router.

@kof kof requested a review from TrySound December 3, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants