Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WELD-2808 Allow injection of ELAwareBeanManager #3117

Merged
merged 2 commits into from
Feb 17, 2025
Merged

WELD-2808 Allow injection of ELAwareBeanManager #3117

merged 2 commits into from
Feb 17, 2025

Conversation

Azquelt
Copy link
Contributor

@Azquelt Azquelt commented Feb 17, 2025

Allow ELAwareBeanManager to be injected, as required in the Web Profile spec

For WELD-2808

@Azquelt Azquelt requested a review from manovotn as a code owner February 17, 2025 15:35
manovotn
manovotn approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR along with a nice test!

@Azquelt I assume this needs a quick release as it might be blocking some TCKs?

@manovotn manovotn merged commit 1ef871a into weld:master Feb 17, 2025
12 checks passed
@Azquelt
Copy link
Contributor Author

Azquelt commented Feb 17, 2025

At the moment I think it doesn't cause a TCK failure but it should. I was working through my remaining TODOs and one of them was testing this.

I get no hits for ELAwareBeanManager on platform-tck so I will open a similar PR there.

I don't have a strict timeline for this, but a release relatively soon would be good.

@Azquelt Azquelt deleted the elaware-bm-injection branch February 17, 2025 17:00
@manovotn
Copy link
Contributor

@Azquelt Weld 6.0.1.Final should be in Central by now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Azquelt @manovotn