Add prismic linting step for audio/video duration format (xx:xx) #11188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcantin-w
approved these changes
Sep 18, 2024
| function detectIncorrectAudioVideoDuration(doc: any): string[] { | ||
| const guideStopSlices = | ||
| doc?.data?.slices?.filter(s => s.slice_type === 'guide_stop') || []; | ||
| const regex = /^(\d{2,}:)?[0-5][0-9]:[0-5][0-9]$/; // e.g. 03:30 (optionally 01:03:30) |
There was a problem hiding this comment.
nice one 👍 thanks for explaining it too
|
Happy for it to go in with the Jason "error" still there so you can test, if you want to run the linter manually and see it pop up 🤷♀️ with or without! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We've changed the Guide Stop audio/video duration fields to be strings rather than numbers, and we're requesting that editors enter them in the format xx:xx but we can't validate this at the point of data entry (because Prismic) so this adds a rule to the
lintPrimsicscript to check the duration strings against a regex that expects {number}{number}:{number}{number}.How to test
I deliberately entered the last of the video durations for Jason as
4:37(instead of04:37) to verify that we're catching the errors. I'm planning on updating this, but can wait if you'd also like to test it yourselves.How can we measure success?
Site has consistent guide-stop durations
Have we considered potential risks?
A guide stop with a/v durations longer than an hour would cause issues. Might be worth making the regex a bit more tolerant?<– did this