Add steps for e2e tests (if necessary) step not to run on main #11195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Following #11183 it was noticed that the
"Add steps for e2e tests (if necessary)"was still run onmaineven though it doesn't do anything (we run e2e tests in the deployment pipeline formain)See: https://wellcome.slack.com/archives/CUA669WHH/p1726676801756259
How to test
When merging something to
maincheck the wc.org: build + test pipeline. It should not have a "Add steps for e2e tests (if necessary)" step.How can we measure success?
Less noise in the pipeline.
Have we considered potential risks?
This step currently fails gracefully and doesn't do anything.