Remove egWorks toggle/conditions & legacy QR codes support
#11197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1.16 kB (-0.12%) Total Size: 982 kB
ℹ️ View Unchanged
|
rcantin-w
commented
Sep 19, 2024
Comment on lines
-77
to
-79
| // TODO remove 'captions-and-transcripts' once we close Jason/migrate it | ||
| // as we no longer set a cookie for that type. | ||
| // https://github.com/wellcomecollection/wellcomecollection.org/issues/11131 |
There was a problem hiding this comment.
We still need it for other things, like the page title, so won't do.
rcantin-w
changed the title
egWorks toggle/conditions & legacy QR codes support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
#11131 tidies the codebase after
egWorkshas successfully been made public, and we stop supporting legacy QR codes. As we've moved Jason over and it was the only one still using them, this should be good to go.getTypeColor()helper function as we don't use those colours on DG anymoreegWorksconditions and the togglecontent/webapp/pages/guides/exhibitions/[id]/[type]/index.tsxas we do not point to that page from QR codes anymore.Note
There is still tidying work to do once we've migrated all legacy Exhibition Guide content types. They should be identified and done after #11181 is completed.
How to test
Run locally, do all affected pages still lookgood? Look at a legacy exhibition (In Plain Sight) and a new one (Hard Graft)
How can we measure success?
Tidier code, easier to read and make changes to.
Have we considered potential risks?
QA should cover visual risks, and e2es as well.