Move isUserStaffWithRestricted at the user context level #11378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcantin-w
changed the title
|
Size Change: +40 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
|
I'm no longer seeing the view item link on the works page for restricted items, when I'm logged in |
|
There was a typo in the role name 😄 ( |
That's what reviews are for 😃 |
gestchild
approved these changes
Nov 11, 2024
|
Think you just need to merge in main to fix the broken e2e tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Makes use of the User Context and adds a check of whether or not the user has the
StaffWithRestrictedrole. We did this check in various places, so I thought it might be good to have it at a higher level. This is very much a suggestion though, as I was going through the files and wondering how we could use Contexts for the item viewer. So we can just close this if it's not wanted!How to test
Ensure behaviour doesn't change in affected files.
How can we measure success?
No need for repetitive code for the check no more
Have we considered potential risks?
If we QA this and the conditions make sense, risk should be very low.