Fix: Remove trailing spaces in numberToEnglish and improve code consistency#7
Open
open-inspect-wesmith4[bot] wants to merge 1 commit into
Open
Conversation
…e consistency - Add .trim() to numberToEnglish result to eliminate trailing spaces - Update test cases to expect properly formatted output without trailing spaces - Replace .substring() with .slice() in addCommas for consistency - All tests now pass with corrected expectations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the top issues identified in the code review:
.trim()to remove trailing spaces from the result string.substring()with.slice()in addCommas for cleaner, more idiomatic JavaScriptChanges
exercises/numberToEnglish/numberToEnglish.js.trim()call when joining descriptionWords to eliminate trailing spacesexercises/addCommas/addCommas.jsnumberString.substring(0, numberString.length - 3)withnumberString.slice(0, -3)for consistencyTesting
All tests pass after changes:
Created with Open-Inspect