Repository navigation
feat(tempo): add hardfork selection - #110
Conversation
commit: |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0efa526045
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: { | ||
| RUST_LOG, | ||
| }, | ||
| })`${[binary, ...command({ ...args, chain, port })]}`, |
There was a problem hiding this comment.
When local Tempo instances run sequentially on the same port with different hardfork values—particularly the default port—this still lets command() select /tmp/.prool/tempo.${port} regardless of the fork. That directory survives stop(), so the second instance can open a database containing blocks and state produced under the previous fork schedule while receiving the newly rewritten genesis; depending on Tempo's database checks, it either fails to start or silently invalidates the intended fork-specific experiment. Derive the default datadir from the selected hardfork or clear it when the schedule changes, while continuing to honor an explicitly supplied datadir.
Useful? React with 👍 / 👎.
Add
hardforkto Tempo binary and container instances. Configure genesis to activate the selected fork and its predecessors while disabling later forks, enabling tests against a specific activation schedule.