-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use Sourcify v2 API in sourcify plugin #4629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: c64d581 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update this script too
https://github.com/wevm/wagmi/blob/main/scripts/updateBlockExplorerPluginChains.ts#L30
Co-authored-by: awkweb <[email protected]>
It appears the script you mentionned @tmm is using a non-deprecated API endpoint. The Sourcify documentation still lists it under ”Others”: https://docs.sourcify.dev/docs/api/#other Do you think there is something to be done there? |
Hey thanks! This works too but you can also use The |
Got it, I'll update this PR to use that instead |
This PR upgrades the Sourcify plugin API endpoint from the deprecated V1 to the V2 endpoint.
FYI, it should also solve an issue where it was not possible to fetch partial-matched contracts. I hope this doesn’t break anything, but the V2 API does not seem to make the distinction anymore.
See here: https://docs.sourcify.dev/docs/api/