New param to decide to close the bottom of the object #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the object during capture is place on the board you are never able to see the bottom of the object. During reconstruction this leads to creating a hole in the object that does not actually exist.
Like proposed there wg-perception/capture#18 , I guess the proper way would be to flip the object and do a second capture, then use some alignment algorithm in PCL to get a fusion of the two capture and hence get a full object for reconstruction.
For now, I am worked a little on the Meshlab scripts and found a way to add a flat bottom to the object by using its convex hull. You just have to use the
--close
flag to add a bottom to the object.See the difference here:
I have tested it on several objects, and it seems to work fine.
This is a fine temporary hack before we code a nice way of aligning twoo set of captures.
For example, my hack won't fix this, because there is no points below the camera lens