Merged
Conversation
When an attribute is appended to an element or is replacing an existing attribute, we need to ensure that its node document remains accurate. Fixes #1359.
Member
|
Can this be tested? jsdom doesn't implement this and I'm not aware of it failing any related tests. |
smaug----
approved these changes
Feb 19, 2025
Contributor
smaug----
left a comment
smaug----
left a comment
There was a problem hiding this comment.
yeah, a test would be good. Given the recent findings in implementations and spec, I wouldn't be surprised if this is broken in various places.
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 20, 2025
Member
Author
|
Created tests, no surprises in browsers. |
domenic
approved these changes
Feb 21, 2025
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 21, 2025
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 28, 2025
…estonly Automatic update from web-platform-tests DOM: test attribute's node document For whatwg/dom#1360. -- wpt-commits: 40dc07cac81f40bf4086c2c7fdd8a0b68fecbcd0 wpt-pr: 50835
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 1, 2025
…estonly Automatic update from web-platform-tests DOM: test attribute's node document For whatwg/dom#1360. -- wpt-commits: 40dc07cac81f40bf4086c2c7fdd8a0b68fecbcd0 wpt-pr: 50835 UltraBlame original commit: 17457f3cb5175dc0f642fc00e937868eccb90acd
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 1, 2025
…estonly Automatic update from web-platform-tests DOM: test attribute's node document For whatwg/dom#1360. -- wpt-commits: 40dc07cac81f40bf4086c2c7fdd8a0b68fecbcd0 wpt-pr: 50835 UltraBlame original commit: 17457f3cb5175dc0f642fc00e937868eccb90acd
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 1, 2025
…estonly Automatic update from web-platform-tests DOM: test attribute's node document For whatwg/dom#1360. -- wpt-commits: 40dc07cac81f40bf4086c2c7fdd8a0b68fecbcd0 wpt-pr: 50835 UltraBlame original commit: 17457f3cb5175dc0f642fc00e937868eccb90acd
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 5, 2025
…estonly Automatic update from web-platform-tests DOM: test attribute's node document For whatwg/dom#1360. -- wpt-commits: 40dc07cac81f40bf4086c2c7fdd8a0b68fecbcd0 wpt-pr: 50835
glandium
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Apr 1, 2025
…estonly Automatic update from web-platform-tests DOM: test attribute's node document For whatwg/dom#1360. -- wpt-commits: 40dc07cac81f40bf4086c2c7fdd8a0b68fecbcd0 wpt-pr: 50835
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an attribute is appended to an element or is replacing an existing attribute, we need to ensure that its node document remains accurate.
Fixes #1359.
Preview | Diff