Added a duplicate attribute present member to element #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
html PR: whatwg/html#4223 |
|
@annevk Hi Anne, could I bother you to look at this PR? |
|
Nothing wrong here as far as I can tell, though it makes me wonder whether we can deduplicate somehow. Leaving this until whatwg/html#4223 (review) is resolved though. |
andypaicu
force-pushed
the
add-element-duplicate-attribute
branch
from
b9b0567 to
6e7a22b
Compare
andypaicu
force-pushed
the
add-element-duplicate-attribute
branch
from
6e7a22b to
2f7799e
Compare
|
I've updated this PR to match the changes in the HTML PR. |
|
After some more feedback this change turns out not to be needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: whatwg/html#3257
Added a
duplicate attribute presentmember toElementModified create an element algorithm to accept a
duplicate attribute presentflag to save it on theElementThis will be used in https://w3c.github.io/webappsec-csp/#is-element-nonceable.
Preview | Diff