Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: initialize a response does not have an optional argument #1721

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Editorial: initialize a response does not have an optional argument #1721

merged 1 commit into from
Nov 7, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 7, 2023 •
edited by pr-preview bot
Loading

@annevk
Copy link
Member Author

annevk commented Nov 7, 2023

@lucacasonato we overlooked this as part of b3bfd0c. Does this seem reasonable to you?

lucacasonato
lucacasonato approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM

@annevk annevk merged commit 1df00b1 into main Nov 7, 2023
2 checks passed
@annevk annevk deleted the annevk/null-vs-optional branch November 7, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @lucacasonato