Fix focus navigation scope owner for popovers

[josepharhar]

The focus navigation scope owner was erroneously set to the popover itself for popovers, when it should be the popover's invoker element.

Fixes #11159

• At least two implementers are interested (and none opposed):
  • Chromium (already implemented)
  • Gecko (already implemented)
  • WebKit (already implemented)
• Tests are written and can be reviewed and commented upon at:
  • https://wpt.fyi/results/html/semantics/popovers/popover-focus.html
• Implementation bugs are filed:
  • Chromium: N/A, already implemented
  • Gecko: N/A, already implemented
  • WebKit: N/A, already implemented
• Corresponding HTML AAM & ARIA in HTML issues & PRs: I don't believe this needs anything in aria.
• MDN issue is filed: I don't believe this needs anything in MDN.
• The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

---

/interaction.html ( diff )

[domenic]

Editorially LGTM. Perhaps @EdgarChen can review too?

Please fill out the template for bug fixes like this too. Most of the entries can be N/A or already implemented, but it helps us as editors understand the status of the PR better.

[EdgarChen]

LGTM. Thank you!

[josepharhar]

Thanks, I filled out the OP

[nt1m]

WebKit (already implemented)

This is not what WebKit implements. WebKit follows the "broken" spec since WebKit/WebKit@6e3d19b .

In principle, changing it to follow this PR shouldn't be hard and without behavior changes but it's an unnecessary effort that can cause regressions though.

[nt1m]

(In case you're wondering how WebKit passes the focus tests, there are a few hacks there and there to make it work with the invokers, but I found that the choice of scope owner doesn't really reduce the number of hacks, it just moves them to different places)

[josepharhar]

Thanks for the clarification! Do you think that making the invoker a focus scope owner is bad and should be changed? If so, do you have an example to highlight it?

[nt1m]

Thanks for the clarification! Do you think that making the invoker a focus scope owner is bad and should be changed? If so, do you have an example to highlight it?

There's honestly no difference for developers, it's more a matter of choice regarding how code is organized