Skip to content

Conversation

domenic
Copy link
Member

@domenic domenic commented Jul 15, 2025

  • Change the behavior of the dataset named setter.
  • Change the conformance-related definitions for custom data attributes and custom element attributes.

Closes #11439.

(See WHATWG Working Mode: Changes for more details.)


/custom-elements.html ( diff )
/dom.html ( diff )
/infrastructure.html ( diff )

* Change the behavior of the dataset named setter.
* Change the conformance-related definitions for custom data attributes and custom element attributes.

Closes #11439.
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't quite realize this when we made the change for custom elements, but this does mean that HTML and XHTML have now diverged in what they can express. This was already the case to some extent in various scenarios so that's probably okay.

@josepharhar
Copy link
Contributor

I implemented the dataset logic in chromium already because the code for setAttribute which looks at the name validation is called by the dataset code. WPT was updated here: https://github.com/web-platform-tests/wpt/pull/53251/files#diff-cc0595be8cdff8311f0c29be67f13dfecfba203b2a8966b7353dfb8f341d701c

I'm guessing that the custom elements changes are not testable.

@domenic
Copy link
Member Author

domenic commented Jul 16, 2025

Thanks very much @josepharhar! Then, let me merge this, under the assumption we have enough Gecko and WebKit support to proceed. If that turns out to be a bad assumption, I will revert.

@domenic domenic merged commit 841fcfd into main Jul 16, 2025
2 checks passed
@domenic domenic deleted the xml-name-prod branch July 16, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove XML name validation from dataset named property setter
3 participants