- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3k
Declarative CSS Modules #11687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            KurtCattiSchmidt
  wants to merge
  20
  commits into
  whatwg:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
KurtCattiSchmidt:css-modules-firstpr
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +186
        
        
          −5
        
        
          
        
      
    
  
  
     Open
                    Declarative CSS Modules #11687
Changes from all commits
      Commits
    
    
            Show all changes
          
          
            20 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      7f91f78
              
                Initial commit
              
              
                KurtCattiSchmidt b8c96ae
              
                Adding missing shadowrootadoptedstylesheets and other small fixes
              
              
                KurtCattiSchmidt 4487b30
              
                Addressing Hoch's feedback
              
              
                KurtCattiSchmidt fde2e28
              
                Fixing order and removing duplicate shadowrootadoptedstylesheets
              
              
                KurtCattiSchmidt 141c474
              
                Fixing shadowrootadoptedstylesheets to definition to not include clon…
              
              
                KurtCattiSchmidt c174820
              
                Wrapping algorithm per new requirements
              
              
                KurtCattiSchmidt 477caa7
              
                Fixing formatting
              
              
                KurtCattiSchmidt 582566e
              
                Merge branch 'main' into css-modules-firstpr
              
              
                KurtCattiSchmidt ccac8fe
              
                Fixing <li> conformance error
              
              
                KurtCattiSchmidt 746cdad
              
                Simplifying stylesheet adopting steps
              
              
                KurtCattiSchmidt ca450c7
              
                Making stylesheet adopting steps append instead of set
              
              
                KurtCattiSchmidt d8cae13
              
                Fixing typo
              
              
                KurtCattiSchmidt 11fcb56
              
                Addressing Dan's feedback
              
              
                KurtCattiSchmidt 9e2f7ee
              
                Minor style fixes
              
              
                KurtCattiSchmidt b2c6025
              
                Addressing Dan's second round of feedback
              
              
                KurtCattiSchmidt adf1484
              
                Updating external URL references to draft URL's
              
              
                KurtCattiSchmidt 05edbed
              
                Adding component percent-encode set per Anne's feedback
              
              
                KurtCattiSchmidt 6cee43f
              
                Separating JSON string step into a JSON object + stringify
              
              
                KurtCattiSchmidt 6a95872
              
                Updating wording on the 'type' attribute being obselete
              
              
                KurtCattiSchmidt 188162a
              
                Converting Import Map to Blob
              
              
                KurtCattiSchmidt File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
          Some comments aren't visible on the classic Files Changed page.
        
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is also the point where we'd also check a new equivalent of the already started flag to ensure a given
<style type=module>only ever gets processed once?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll have to think about this a little more. I will likely bring this up soon with the WHATWG.