-
Notifications
You must be signed in to change notification settings - Fork 3k
Add support for WebDriver BiDi language emulation #11793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for WebDriver BiDi language emulation #11793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, but now that you're making these algorithms more complex, you should turn them into a list of steps similar to most other algorithms. Then they will become easier to read.
Co-authored-by: Maksim Sadym <[email protected]>
|
The WebDriver BiDi part is merged. So this should be ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Informal LGTM
The PR to add the required hook in WebDriver BiDi spec: w3c/webdriver-bidi#1017.
emulation.setLocaleOverrideinnavigator.languageandAccept-LanguageGoogleChromeLabs/chromium-bidi#3863(See WHATWG Working Mode: Changes for more details.)
/acknowledgements.html ( diff )
/infrastructure.html ( diff )
/system-state.html ( diff )