Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev edition: Hide ruby algorithm parts #2804

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Dev edition: Hide ruby algorithm parts #2804

merged 1 commit into from
Jul 5, 2017

Conversation

momdo
Copy link
Contributor

@momdo momdo commented Jul 1, 2017

According to #1488 (comment) .

domenic
domenic reviewed Jul 5, 2017
View reviewed changes
source Outdated
@@ -20307,6 +20307,8 @@ this specification: the <abbr>WHATWG</abbr> and the

<hr>

<div w-nodev>

<p>Within a <code>ruby</code> element that does not have a <code>ruby</code> element ancestor,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still include most of this paragraph, probably? Except the last sentence. I will amend to do so, but let me know if you disagree.

@domenic
Copy link
Member

domenic commented Jul 5, 2017

I've rebased so this doesn't have the IANA commits and merge commits, and tweaked so that it doesn't hide the semantics part of the intro paragraph, just the algorithm and the note about how the concepts are represented in the algorithm.

Thanks so much for this!

@domenic domenic merged commit 5f80a44 into whatwg:master Jul 5, 2017
@momdo momdo deleted the dev-ruby branch July 14, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic left review comments

Assignees
No one assigned
Labels
dev edition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@momdo @domenic