Modify the RAR signature to match RAR specification #144
Conversation
This changes the RAR signature validation to correct deficiencies stated in whatwg#63 and to separate the signature used in RAR 4.x and RAR 5.0.
|
@gacelperfinian you'll need to sign https://participate.whatwg.org/agreement. It might also help to force push so the bots run again. @GPHemsley Chrome only has one RAR signature right, but this PR adds multiple. It's not clear we have implementer agreement for such a change. |
There was a problem hiding this comment.
@gacelperfinian The correction of the typo in the RAR 4.x signature is the desired change here. Please remove the addition of the RAR 5 signature, as that would warrant a separate discussion.
As stated in whatwg#144 (review): > Please remove the addition of the RAR 5 signature, as that would warrant a separate discussion.
There was a problem hiding this comment.
@GPHemsley sorry for the delay due to personal circumstances. I've made the necessary change since as you pointed out, the popularity (or not) of RAR 5 files should warrant a separate review.
@annevk I've already submitted the contrib agreement but still awaiting WHATWG's verification.
This changes the RAR signature validation to correct deficiencies stated in #63 and to separate the signature used in RAR 4.x and RAR 5.0.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff