-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stages policy #227
Add Stages policy #227
Conversation
Co-authored-by: Anne van Kesteren <[email protected]>
Co-authored-by: Jeremy Roman <[email protected]>
Co-authored-by: Domenic Denicola <[email protected]>
Co-authored-by: Domenic Denicola <[email protected]>
Co-authored-by: Domenic Denicola <[email protected]>
Co-authored-by: Domenic Denicola <[email protected]>
Co-authored-by: Domenic Denicola <[email protected]>
Co-authored-by: Domenic Denicola <[email protected]>
Remove subtitle, add <dfn>s, THEAD structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for working on this. I think this is a valuable addition to the WHATWG.
The inline comments note a couple instances, but I would suggest we generally replace "feature" / "proposal" / ... with "Contribution" and link that to https://whatwg.org/ipr-policy#21-contribution. Similarly linking "Contributor" to https://whatwg.org/ipr-policy#contributor would be good (and consistently calling the person making the Contribution a Contributor).
That more clearly establishes how this works within our existing set of policies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Cross-document links should be done as we do in other Markdown documents. The idea is that you can click around the Markdown documents and essentially stay in that "unpublished universe".
- Terms like Contribution and Contributor need to be linked, as they are in other Markdown documents.
- Please search for ". " (two spaces) and replace with ". " (single space).
- There's still quite a few occurrences of "feature" or "proposal" that should be "Contribution". And similar for "Contributor"-like terms. Generally the less unique terms we use the better.
If you want I'd be happy to do a pass and then you can leave feedback for me. Just say the word.
Addressing #227 (comment).
addressing #227 (comment)
Co-authored-by: Anne van Kesteren <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
Note there are four occurrences of "feature" that should remain.
Note there is one intention use of "proposal".
Done in 97f07c1.
Done in 8d24ac2, b2b46b7, 580c083, 7dac695.
Done in 96f0352.
Fixed in a525b11, 38523d0, and 37ffba4. Note there are still some intentional occurrences of "feature" and "proposal", when they are not specifically referring to the Contribution. |
Anne, you are more than welcome to take a pass at this directly if you would prefer. Given your comment at last week's WHATNOT meeting, I'm going to go ahead and merge this soon, and we can further iterate if necessary. |
@cwilso I'd like to be the one merging this unless you take responsibility for rolling it out on whatwg.org. I ran Please take a look at the changes I pushed. |
I think we might need some kind of styling for the table actually. https://html5.org/temp/whatwg-stages.html looks pretty awful. Minimally something like
@domenic @zcorpan any thoughts on that? I've put up whatwg/whatwg.org#436 for this. |
Needed for whatwg/sg#227. Also update .gitignore while here.
Agreed more styling is needed, and I think some borders and padding aids readability further. On a narrow screen, the table overflows to the right, so setting a white background color is good.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Needed for whatwg/sg#227. Also update .gitignore while here.
(This includes changes from previous PR #222.)