Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Trivial Changes description to Workstream Policy #228

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

tantek
Copy link
Member

@tantek tantek commented Mar 12, 2024

Insert agreed and approved "Trivial Changes" definition from #63 (comment) into our Workstream Policy per agreement in #63 (comment)

Insert agreed and approved "Trivial Changes" definition from #63 (comment) into our Workstream Policy per agreement in #63 (comment)
@tantek tantek requested review from cwilso and annevk March 12, 2024 17:43
Copy link
Contributor

@cwilso cwilso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should replace "change(s)" with "contribution(s)" throughout in this new section. I think that would be slightly better.

Workstream Policy.md Outdated Show resolved Hide resolved
Workstream Policy.md Outdated Show resolved Hide resolved
@tantek tantek added the agenda On the agenda for the next SG meeting label Mar 21, 2024
tantek and others added 2 commits June 18, 2024 10:18
Used "trivial contribution(s)" consistently to refer to the concept, and only refer to change or changes when it is the literal meaning in context in a sentence. Good suggestion @annevk
@tantek tantek requested a review from annevk June 18, 2024 19:45
Workstream Policy.md Outdated Show resolved Hide resolved
@annevk annevk merged commit c8579b7 into main Jun 19, 2024
1 check passed
@annevk annevk deleted the tantek-patch-1 branch June 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agenda On the agenda for the next SG meeting
Development

Successfully merging this pull request may close these issues.

4 participants