-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WritableStreamDefaultController.releaseBackpressure() #1190
Draft
MattiasBuelens
wants to merge
13
commits into
whatwg:main
Choose a base branch
from
MattiasBuelens:ws-release-backpressure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7fddf5e
Add WritableStreamDefaultController.releaseBackpressure()
MattiasBuelens ceaf04e
Use releaseBackpressure() in TransformStream pull() algorithm
MattiasBuelens 7b24e7f
Roll WPT
MattiasBuelens 265c346
Ignore releaseBackpressure() if there are queued chunks
MattiasBuelens 90b00cb
Roll WPT
MattiasBuelens cf30f6e
Fix "is empty" links in spec text
MattiasBuelens fc0cb9d
Update spec text
MattiasBuelens 95323e7
Reset flag before processing a new chunk
MattiasBuelens 96c8cd1
Roll WPT
MattiasBuelens ad88916
Add HWM and size algorithms to "set up a TransformStream"
MattiasBuelens 1eafb51
Set writable HWM to 0 in "create an identity TransformStream"
MattiasBuelens 976492b
Remove custom ID for new abstract op
MattiasBuelens 89292d3
Add missing !
MattiasBuelens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have separate set up algorithms for sync vs. async transforms, and thus take away the responsibility of picking the right high water mark from the other spec author. So far other specs haven't needed these extra customization points and I think it might be simpler not to give them out.
(On the other hand, the fact that existing byte-stream-transform specs are calculating the size of all chunks as 1 is a bit unfortunate...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I remove the HWM and size algorithm arguments from "set up a
ReadableStream
" and "set up aWritableStream
" too then?Hmm, true. Once we have proper byte support for
WritableStream
andTransformStream
, we'll have "set up with byte reading support" versions for those too, but for now we're in a bit of an awkward position. 😕Maybe we can already provide such algorithms, even though they won't vend BYOB readers or BYOB writers yet?