Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property descriptions in the quick reference #194

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Oct 17, 2023

No description provided.

@jeremyroman
Copy link
Collaborator

Looks reasonable to me (well, we could bikeshed scheme/protocol, path/pathname and hash/fragment, but it probably doesn't matter in this context). Unfortunately I seem to not have been granted permission to review PRs since this was moved into whatwg.

@domenic do you know what's required for that?

Copy link
Collaborator

@sisidovski sisidovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM unless we have bikeshedding.

@jeremyroman should have the permission to review (because I have the permission), maybe a setting mistake happened while the transfer?

@domenic
Copy link
Member

domenic commented Oct 18, 2023

#195 might be relevant here.

Yes, both of you have the same permissions; Jeremy please try again?

@jeremyroman
Copy link
Collaborator

I was able to approve, but I'm still not authorized to merge PRs due to branch protection.

@domenic
Copy link
Member

domenic commented Nov 4, 2023

I found a setting that seemed different between this and other standards. Give it a shot now?

@jeremyroman jeremyroman merged commit 0343b0b into main Nov 6, 2023
1 check passed
@jeremyroman jeremyroman deleted the zcorpan/quick-reference-fixes branch November 6, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants