-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose URLPattern everywhere #236
base: main
Are you sure you want to change the base?
Conversation
I've drafted a set of criteria for which interfaces to expose universally on all globals, at w3ctag/design-principles#510. URLPattern looks like it fits those criteria and is useful to have in any environment.
Conceptually makes sense to me, but would like to see w3ctag/design-principles#510 settled. Browsers (well, at the moment, Chromium) shipping this probably does imply a web-facing change albeit a minor one. Does this confine the future evolution of |
Thanks! I will proceed with writing tests and filing implementation bugs when the design-principles issue is settled, then. I don't believe this would prevent adding members in future that wouldn't be exposed everywhere. For example, AbortSignal has a |
@jeremyroman The design-principles issue is settled (https://www.w3.org/TR/design-principles/#expose-everywhere) so I think this can be moved forward. What should the next steps be? From my side, a review of the tests in web-platform-tests/wpt#49323 would be great. |
Makes sense to me for this to be |
Still catching up with the context but generally the change sounds reasonable. @ptomato Do you have other ongoing (or merged) PRs to expose some APIs everywhere? e.g. the design principle says TextEncoder is a good example. |
@sisidovski Yes, here are the others:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
I think you can fill the checkbox in the description?
I've drafted a set of criteria for which interfaces to expose universally on all globals, at
w3ctag/design-principles#510. URLPattern looks like it fits those criteria and is useful to have in any environment.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff