Editorial: add missing args for CreateBuiltinFunction #1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Nov 11, 2025
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
This looks good to me. Might be good if someone else takes a look too though, maybe @Ms2ger or @saschanaz?
Member
|
You'll also have to complete https://participate.whatwg.org/agreement. |
Contributor
Author
When I try to submit the agreement, I get the error message: "Email is already present in the system". However, it seems that the participant data is still added to individuals.json. |
Member
|
Oh that's weird, not sure what would have caused that as your email address does appear to be unique. |
Ms2ger
approved these changes
Nov 11, 2025
Member
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
This seems reasonable. Are the length/name observable for any of the functions that didn't previously have them defined explicitly?
Co-authored-by: Ms2ger <[email protected]>
Co-authored-by: Ms2ger <[email protected]>
Co-authored-by: Ms2ger <[email protected]>
Co-authored-by: Ms2ger <[email protected]>
Co-authored-by: Ms2ger <[email protected]>
annevk
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
lengthandnamearguments for CreateBuiltinFunction were missing.This PR adds them to align with the ECMAScript specification.
Preview | Diff