Fix mineHookAddress method for non-ETH numeraire support#12
Open
Segfaultd wants to merge 2 commits intowhetstoneresearch:mainfrom
Open
Fix mineHookAddress method for non-ETH numeraire support#12Segfaultd wants to merge 2 commits intowhetstoneresearch:mainfrom
Segfaultd wants to merge 2 commits intowhetstoneresearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
mineHookAddressmethod inDopplerFactory.tsonly worked correctly with ETH (0x0000...) as numeraire but failedwith ERC20 tokens as numeraire due to incorrect token ordering logic.
Solution
numeraireBigInt < tokenBigIntlogic for correct token0/token1 orderingChanges
mineHookAddressmethod token ordering logicBefore
After
Testing
References
Backports fix from previous SDK version PR #142