Skip to content

feat: make multicurve tick warnings context-aware#49

Open
rustydotwtf wants to merge 1 commit intomainfrom
feat/context-aware-tick-warnings
Open

feat: make multicurve tick warnings context-aware#49
rustydotwtf wants to merge 1 commit intomainfrom
feat/context-aware-tick-warnings

Conversation

@rustydotwtf
Copy link
Collaborator

Summary

  • Updated normalizeMulticurveCurves in DopplerFactory.ts to be aware of the numeraire address.
  • Implemented logic to check isToken0Expected(numeraire) to determine if ticks should be positive or negative.
  • Now only warns if ticks have the "wrong" sign for the expected token ordering (e.g. negative ticks for Mainnet WETH, positive ticks for Base WETH).
  • Removed the blanket "negative ticks" warning which was a false positive for the most common use case (Base WETH).
  • Added tests covering:
    • Warning on negative ticks when positive expected.
    • Warning on positive ticks when negative expected.
    • No warning when ticks match expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants