Skip to content

Conversation

@Geph
Copy link
Member

@Geph Geph commented Aug 9, 2024

A quick fix to allow for differing levels for precision in results. Conversions now use a fixed 3 point precision, base numbers use whatever variable is assigned in the config. The reason is that we had too many kids misread the "." and mistake it for a "," and write things like "the gravity is 1000 times that of earth", when it was being expressed as "1.000 times" - I've reworded some of the science tools to match how kids can more logically interpret them: pressure, gravity and radiation are now all "%" of what they would be on earth as the default measure, with specific units that they don't really understand written in the parenthesis in high-precision. So Mars has "38% of earth's gravity" but that's then expressed as 3.727 m/s^2.

A smarter way to do this would be to have a config option for either separate precision for each conversion OR a T/F option for a given science tool to be expressed as percentage. That said my change could be done altering 2 characters in just two files and didn't break anything so I'm going with it for now. Jack I understand if you don't want to merge this and want to do it the right way. I'll make another attempt on this branch for you to review if I can.

@Geph Geph requested a review from jackah2 August 9, 2024 06:55
…for each conversion? I am but a todler trying to operate a spaceship.
@Geph
Copy link
Member Author

Geph commented Aug 9, 2024

I think I did it but in the process created scary warnings above my paygrade:

maven-shade-plugin has detected that some class files are
present in two or more JARs. When this happens, only one
single version of the class is copied to the uber jar.
Usually this is not harmful and you can skip these warnings,
otherwise try to manually exclude artifacts based on
mvn dependency:tree -Ddetail=true and the above output.

Geph added 2 commits August 9, 2024 01:29
…for each conversion? I am but a todler trying to operate a spaceship.
…for each conversion? I am but a todler trying to operate a spaceship.
@Geph
Copy link
Member Author

Geph commented Aug 9, 2024

Fixed all the checkstyle stuff but it doesn't recognize it. Leaving it here for Jack to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants