Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segment_key_values doesn't create explicit segments when passed as a parameter into why.log #1561

Open
1 task done
jamie256 opened this issue Sep 11, 2024 · 0 comments
Open
1 task done

segment_key_values doesn't create explicit segments when passed as a parameter into why.log #1561

jamie256 opened this issue Sep 11, 2024 · 0 comments

Comments

@jamie256
Copy link
Contributor

jamie256 commented Sep 11, 2024 •
edited
Loading

Description

when calling whylogs like this:

why.log(df, segment_key_values={segment_key: segment_value})

whylogs should return a SegmentedResultSet with an explicit segment defined by the segment_key_values
@jamie256 jamie256 mentioned this issue Sep 11, 2024
Merged
1 task
jamie256 added a commit that referenced this issue Sep 11, 2024
@jamie256
Add support for manual segmentation with segment_key_values (#1562)
9a34c0e 
## Description

Addresses #1561 

now this works:
```python
why.log(df, segment_key_values={segment_key: segment_value})
```

## Changes

- Creates an explicitly defined single segment SegmentedResultSet when
this parameter is passed into whylogs log method.

- [x] I have reviewed the [Guidelines for Contributing](CONTRIBUTING.md)
and the [Code of Conduct](CODE_OF_CONDUCT.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamie256