Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for manual segmentation with segment_key_values #1562

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add support for manual segmentation with segment_key_values #1562

merged 1 commit into from
Sep 11, 2024

Conversation

jamie256
Copy link
Contributor

Description

Addresses #1561

now this works:

why.log(df, segment_key_values={segment_key: segment_value})

Changes

andyndang
andyndang approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamie256 jamie256 merged commit 9a34c0e into mainline Sep 11, 2024
14 checks passed
@jamie256 jamie256 deleted the dev/jamie/segment_key_values branch September 11, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyndang andyndang andyndang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamie256 @andyndang