Skip to content

fix: improve file browser selection visibility in dark mode - #1246

Merged
maartenbreddels merged 1 commit into
masterfrom
fix/file-browser-dark-selection
Oct 6, 2026
Merged

maartenbreddels merged 1 commit into
masterfrom
fix/file-browser-dark-selection

Conversation

@mariobuikhuizen

@mariobuikhuizen mariobuikhuizen commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

File browser selection uses translucent dark gray in both themes, making selected files difficult to distinguish from unselected files in Jupyter dark mode.

Use translucent white for selected rows in dark mode in both the Vue 2 / Vuetify 2 and Vue 3 / Vuetify 3 templates. Keep the existing light-mode color and scope selection styles to the file list.

Validation

  • Vue 2: ipyvue 1.13.0 / ipyvuetify 1.12.0 — 25 file-browser unit tests and 3 browser integration tests passed.
  • Vue 3: ipyvue 3.1.1 / ipyvuetify 3.1.0 — 25 file-browser unit tests and 3 browser integration tests passed.
  • Checked light and dark selection colors in Chromium for both versions.

Screenshots

The same file (first.txt) is selected in each screenshot. Before screenshots use the stylesheet from master; after screenshots use this change.

Version Before After
Vue 2 / Vuetify 2 Before, Vuetify 2 After, Vuetify 2
Vue 3 / Vuetify 3 Before, Vuetify 3 After, Vuetify 3

@mariobuikhuizen
mariobuikhuizen force-pushed the fix/file-browser-dark-selection branch from 39b061b to 88c6383 Compare October 6, 2026 11:25
@maartenbreddels
maartenbreddels temporarily deployed to fix/file-browser-dark-selection - solara-stable PR #1246 October 6, 2026 11:25 — with Render Destroyed
@maartenbreddels
maartenbreddels merged commit 35e0f40 into master Oct 6, 2026
35 checks passed

This branch was successfully deployed

No deployments
fix/file-browser-dark-selection - solara-stable PR #1246 — 88c63832 Deployed Oct 6, 2026 by maartenbreddels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants