Skip to content

feat: add Scrollable component - #1249

Open
ahmedkhan1 wants to merge 1 commit into
widgetti:masterfrom
ahmedkhan1:feat/issue-70-scrollable-component
Open

ahmedkhan1 wants to merge 1 commit into
widgetti:masterfrom
ahmedkhan1:feat/issue-70-scrollable-component

Conversation

@ahmedkhan1

Copy link
Copy Markdown

All Submissions:

  • I installed pre-commit prior to committing my changes.
  • My commit messages conform to conventional commits.
  • My PR title conforms to conventional commits.
  • I linked to the relevant issue.

Changes to / New Features:

  • I included docs for my feature.
  • I wrote tests for my feature.

Description of changes

Adds a public solara.Scrollable layout component backed by the existing Div API. It applies a configurable maximum height and vertical auto-scrolling while preserving custom classes and styles.

The documentation includes a runnable long-Markdown example, and the unit test covers the public export, rendered container, child content, classes, and composed styles.

Closes #70

Validation

  • pytest tests/unit/scrollable_test.py -q (1 passed)
  • pytest tests/unit -q (552 passed, 37 skipped)
  • pre-commit run --all-files (all non-type hooks passed; both full mypy hooks hit the same five existing Windows platform errors in untouched files)
  • changed-file mypy with default and mypy-v3.ini configurations (passed)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Create a solara component for a scrollable text area

1 participant