Skip to content

Add Wikipedia and Template namespace prompt for mobile search menu #5243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

bunnypranav
Copy link
Contributor

@bunnypranav bunnypranav commented Jan 18, 2025

What does this do?

In the namespace list just above the keyboard in the mobile app search menu, Wikipedia: and Template: should be added, in addition to the User: Portal: Help:.

Why is this needed?

Wikipedia and Template namespaces are highly used and visited; they would be really beneficial as an autofill entry suggestion.

Phabricator:
https://phabricator.wikimedia.org/T383797

@bunnypranav bunnypranav force-pushed the T383797 branch 2 times, most recently from 235732f to b679d5e Compare February 13, 2025 12:49
@dbrant
Copy link
Member

dbrant commented Feb 13, 2025

Thanks for the contribution!
We will need to discuss with our product managers and/or designers whether this change is necessary, and in what order to put any new namespaces.
I will bring the Phabricator task that you created to our team's next prioritization meeting.

@bunnypranav bunnypranav requested a review from voyagerfan as a code owner March 1, 2025 11:26
@bunnypranav
Copy link
Contributor Author

@dbrant Any update? Thanks!

Add Wikipedia (Project) and Template namespaces to the suggested autofill in mobile search menu per see T383797.
@bunnypranav
Copy link
Contributor Author

@dbrant @cooltey It's been 4 months since I created this, are you interested in reviewing this?

@dbrant
Copy link
Member

dbrant commented May 27, 2025

@dbrant @cooltey It's been 4 months since I created this, are you interested in reviewing this?

Terribly sorry for the delay -- This is now OK to merge, but let's keep the original order of the namespace hints, while including the new ones at the end.

@bunnypranav
Copy link
Contributor Author

@dbrant @cooltey It's been 4 months since I created this, are you interested in reviewing this?

Terribly sorry for the delay -- This is now OK to merge, but let's keep the original order of the namespace hints, while including the new ones at the end.

Sure, no problem.

@bunnypranav
Copy link
Contributor Author

@dbrant Is it possible for you to tell when this change can be seen in the app? I'm not familiar with the deployment schedule for the mobile apps, so asking. Thanks!

@dbrant dbrant merged commit 6775c2f into wikimedia:main May 27, 2025
1 check passed
@dbrant
Copy link
Member

dbrant commented May 27, 2025

@dbrant Is it possible for you to tell when this change can be seen in the app? I'm not familiar with the deployment schedule for the mobile apps, so asking. Thanks!

It will be in the Beta app within the next week or so, and then in the production app within the next two weeks.

@bunnypranav
Copy link
Contributor Author

@dbrant Is it possible for you to tell when this change can be seen in the app? I'm not familiar with the deployment schedule for the mobile apps, so asking. Thanks!

It will be in the Beta app within the next week or so, and then in the production app within the next two weeks.

Cool, thanks! 😄

@bunnypranav bunnypranav deleted the T383797 branch May 27, 2025 13:31
cooltey added a commit that referenced this pull request May 28, 2025
…nboarding-design

* recommended-reading-list-design:
  Provide a default ripple effect for all Composables. (#5598)
  Simplify detection of Dark theme in WikiCard composable. (#5597)
  Add Wikipedia and Template namespace prompt for mobile search menu (#5243)
  Localisation updates from https://translatewiki.net. (#5592)
  Bump org.maplibre.gl:android-sdk from 11.8.8 to 11.9.0 (#5593)
  - string update (#5591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants