[Feature branch] Recommended reading list #5567
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooltey
added
the
HOLD
* Add preferences and enum classes for Recommended Reading list * Naming * - prefs name rename --------- Co-authored-by: williamrai <[email protected]>
* Only create table if Cateogry table does not exist * Create database table for Recommended Reading list * Lint * Remove "read" and change "expire" to "status" for flexibility * Migrate DB to version 30 * Dont update db 29 json * Change namespace type from text to integer --------- Co-authored-by: William Rai <[email protected]>
cooltey
force-pushed
the
recommended-reading-list-design
branch
from
681da2f to
4c211ae
Compare
* Create onboarding message card for Recommended Reading list * Revert change * Set null for message label * Set container click to true
* Create recurring task for Recommended Reading list * Update viewModel * initial logic to get the recommendations * Recommended source with title, language and offset * Add recurring task * Fininsh the first draft of the algorithm * Bind recommendedPageDao into the recurring task * Additional condition * Uppercase
dbrant
changed the title
…st (#5582) * Build layout * Fix lint * Compose screen * Update compose * Update dao and viewmodel * Remove xml * more logic of handling viewModel * manifest * Add clickable modifier * Finalize and add parameter for settings screen * Code review comments * Proper onclick sources * Use select state * Put logic back * Unused imports * Code review comments * Format a bit * Refine loading indicator
…ist (#5595) * Update the logic of showing onboarding card for Recommended reading list * connect with activity and set the preference to true if complete the onboarding
* - adds ab test for rrl - adds rrl event - adds ab test prefs for rrl * - adds active_interface - adds ab test condition to show rrl onboarding card * - code updates
* - adds discover to general settings - adds Discover activity and compose screen with DiscoverReadingListSwitch functionality * - adds icons - adds articles number option - adds update frequency option - adds a radio list dialog - adds noRippleClickable extension * - removes individual state management to viewmodel state management - also updates the enum RecommendedReadingListUpdateFrequency * - adds discover source, interests and notifications options - adds image resource for notification - adds SettingsSection and new string * - adds a max article number and initial placeholder behavior for ArticlesNumberView * - adds confirmation dialog for discover and notification * - structure change (moves view model to activity and hoist events to activity) - adds snackbar and undo action when discover source is selected - adds updateDiscoverSource function - code and ui fixes * - code fixes - adds a general WikipediaAlertDialog.kt * - fixes format * - ui fixes * - adds consistent naming * - package, files, class rename * - updates no ripple code * - adds preview
* Follow-up: Recommended reading list settings screen * Add settings preference visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T392166