Hide language redirects in the ULS panel #490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Around 30 languages with redirects and variants appear twice in the ULS panel. This fix checks if a redirect exists for a language code, and if it does it updates the target in the languages object and removes the redirect. Bug: T195342
|
@santhoshtr @Abijeet Could we get one of you to help review this patch? |
Abijeet
reviewed
Oct 3, 2024
src/jquery.uls.core.js
Outdated
| @@ -61,6 +61,15 @@ | |||
| // Language is unknown to ULS. | |||
| delete this.languages[ code ]; | |||
| } | |||
|
|
|||
| // Check if the language code is a redirect | |||
| var target = $.uls.data.isRedirect( code ); | |||
There was a problem hiding this comment.
this.options.languages is initialized to $.uls.data.getAutonyms() by default which does not have redirects listed](
jquery.uls/src/jquery.uls.data.utils.js
Lines 93 to 105 in 8b10421
I assume somewhere some custom language options are being passed that necessitates this check. Do we know where this is being done?
src/jquery.uls.core.js
Outdated
|
|
||
| if ( target ) { | ||
| // Update target in the languages object and delete redirect | ||
| this.languages[ target ] = this.languages[ code ]; |
There was a problem hiding this comment.
What happens when the languages list has the original language (ady) and a related redirect (ady-cyrl)? Should we avoid this assignment in such cases?
Around 30 languages with redirects and variants appear twice in the ULS panel. This fix checks if a redirect exists for a language code, and if it does it updates the target in the languages object and removes the redirect. Bug: T195342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Around 30 languages with redirects and variants appear twice in the ULS panel. This fix checks if a redirect exists for a language code, and if it does, it updates the target in the languages object and removes the redirect.
Bug: T195342