sync: 1267-dependency-updates to develop - #384
Merged
Merged
Conversation
WPCS 3.4.1 raised the minimum global-prefix length from 3 to 4 characters, so the theme's `wmf` prefix is now rejected as too short (PrefixAllGlobals.ShortPrefixPassed). Once rejected, the prefix is dropped entirely and every `wmf_*` function, hook, and the `WMF\` namespace is reported as unprefixed, failing phpcs on any PR that touches them. Change the configured prefix to `wmf_`, which every existing global already matches (WPCS treats `_` and `\` as the same separator). No code is renamed; this is purely the linter prefix string. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…-remaining Add donation-bar translations for es_ES, ar, pt_BR (#1241 follow-up)
…wording) The French subsite runs under locale fr-FR, so WordPress looks for fr-FR.mo. The theme shipped only fr_FR.mo, so the catalogue never matched and the donation bar fell back to English on the live /fr/ site. Every other catalogue in the batch is hyphen-named (de-DE, it-IT) and loads correctly; fr_FR was the odd underscore-named file with no matching installed language pack to paper over the mismatch. Rename the catalogue to the hyphen convention and re-sync two donation labels from the client sheet: Give monthly: Tous les mois -> Faire un don mensuel Annual: Tous les ans -> Annuel Recompile fr-FR.mo and set the PO Language header to fr_FR. Refs #1241. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1241: Fix French donation-bar locale (rename fr_FR → fr-FR, re-sync wording)
1231: Fix accordion 'undefined' class + migrate ESLint to flat config (#127)
Lengthen phpcs global prefix to wmf_ for WPCS 3.4.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync-branches: Merge #383 to develop