Support for Ruby 1.9 and string encoding#3
Open
snapvolumes wants to merge 6 commits into
Open
Conversation
- Set "domain = self.target_name" in Type2 #response
…forked gems can find it) 💩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kconv has been replaced in Ruby 1.9, and with the changes to string encoding in Ruby 1.9, we had to make some changes to this to make it work properly with Ruby 1.9.
There was one other minor addition to handle the case where the where domain is blank, which certain web browsers cause