Implemented submit-feature #341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingkwong
requested changes
Oct 7, 2024
| Submit | ||
| </button> | ||
| </div> | ||
| :null |
Comment on lines
+463
to
+466
| <div style={{display:'flex', justifyContent: 'space-between'}}> | ||
| { | ||
| !endQuiz? | ||
| <div style={{ display: 'flex',marginRight:'auto'}}> |
| <div style={{ display: 'flex',marginRight:'auto'}}> | ||
| <button | ||
| onClick={() => {submitQuiz()}} | ||
| style={{ display: 'flex', justifyContent: 'center', backgroundColor: 'green',color:'white' }} |
Comment on lines
+371
to
+375
| const submitQuiz = () => { | ||
| setIsRunning(false); | ||
| setEndQuiz(true); | ||
| getUnansweredQuestions(); | ||
| } |
There was a problem hiding this comment.
the code is same as handleTimeUp. don't duplicate it. revise the function and use for both case.
|
@rohith1222004 are you still interested in finishing this? Can you include a screenshot like #56 (comment) in the PR as well? And if you could make the submit early button configurable: optional (off by default, set some kind of flag to turn it on) and so the caller can decide what to call the submit early button. "Quit" or "Exit" or whatever, depending on the context. Also style wise it should probably look the same as the existing buttons, just copy the relevant classes I'm guessing. Let me know if you need any help with the suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56