Skip to content

Ensure integrations list output is deterministic #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winhowes merged 1 commit into from
Nov 26, 2025
Merged

Ensure integrations list output is deterministic #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmd/integrations/plugins/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package plugins

import "strings"
import (
"sort"
"strings"
)

// Builder defines a function that parses CLI args into an Integration.
type Builder func(args []string) (Integration, error)
Expand All @@ -19,5 +22,6 @@ func List() []string {
for n := range registry {
names = append(names, n)
}
sort.Strings(names)
return names
}
24 changes: 23 additions & 1 deletion cmd/integrations/plugins/registry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package plugins

import "testing"
import (
"sort"
"testing"
)

func TestListReturnsAllRegisteredNames(t *testing.T) {
names := List()
Expand Down Expand Up @@ -48,3 +51,22 @@ func TestGetCaseInsensitive(t *testing.T) {
t.Fatal("case-insensitive Get failed")
}
}

func TestListIsSorted(t *testing.T) {
original := registry
registry = map[string]Builder{
"beta": nil,
"alpha": nil,
"gamma": nil,
"delta": nil,
"epsilon": nil,
}
t.Cleanup(func() { registry = original })

for i := 0; i < 20; i++ {
names := List()
if !sort.StringsAreSorted(names) {
t.Fatalf("List returned unsorted names: %v", names)
}
}
}
Loading