Skip to content

Improve configuration reload error logging #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winhowes merged 1 commit into from
Jan 6, 2026
Merged

Improve configuration reload error logging #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions app/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,13 @@ func applyRemoteFetchTimeout() {
httpClient.Timeout = *remoteFetchTimeout
}

func configSource() string {
if *configURL != "" {
return *configURL
}
return *configFile
}

func loadConfig(filename string) (*Config, error) {
f, err := openSource(filename)
if err != nil {
Expand Down Expand Up @@ -227,13 +234,10 @@ func parseLevel(s string) slog.Level {
func reload() error {
logger.Info("reloading configuration")

src := *configFile
if *configURL != "" {
src = *configURL
}
src := configSource()
cfg, err := loadConfig(src)
if err != nil {
return err
return fmt.Errorf("reload failed for %s: %w", src, err)
}

// Build new integration set without mutating the existing one so we can
Expand Down Expand Up @@ -1365,13 +1369,13 @@ func main() {
select {
case <-reloadSig:
if err := reload(); err != nil {
logger.Error("reload failed", "error", err)
logger.Error("reload failed; keeping existing configuration", "source", configSource(), "error", err)
} else {
logger.Info("reloaded configuration")
}
case <-watchSig:
if err := reload(); err != nil {
logger.Error("reload failed", "error", err)
logger.Error("reload failed; keeping existing configuration", "source", configSource(), "error", err)
} else {
logger.Info("reloaded configuration")
}
Expand Down
Loading