Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major skin refactor: new features #41

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Major skin refactor: new features #41

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0565bf4
Major skin refactor - colors and borders are now handled through js
Tofandel Mar 20, 2019
39b481a
Major skin refactor - colors and borders are now handled through js
Tofandel Mar 20, 2019
76b928c
Maximize Backward compatibility and restore previous formatting
Tofandel Mar 20, 2019
98bcf72
Maximize Backward compatibility and restore previous formatting
Tofandel Mar 20, 2019
a7c2202
Restore the mixin but don't actually use it
Tofandel Mar 20, 2019
3a2b9d0
Fix protip showing only once
Tofandel Mar 20, 2019
fbdf2e6
Fix wrong corner values in doc and tests
Tofandel Mar 20, 2019
26193bf
Fix item instance deletion
Tofandel Mar 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ Protip related attributes will always get a pt namespace so Protip won't conflic
| **auto-hide** | false | *Bool, Number* | Tooltip will hide itself automatically after this timeout (milliseconds). |
| **auto-show** | false | *Bool* | Automatically show tooltip for this element on load (stickies will be shown anyway). |
| **mixin** | undefined | *String* | Tooltip mixins to use. Separated by spaces. |
| **background** | undefined | *String* | You can specify the tooltip background with this option. (Eg: "#333", "rgba(20,20,20,.8)") |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New props should be added to demo also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What demo? Do you mean the test folder or http://protip.rocks/ ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the website.

| **color** | undefined | *String* | You can specify the font color with this option. |
| **border** | undefined | *String* | You can specify the border color with this option, null for no border. (The border will always be 1px) |

## jQuery Helpers
```javascript
Expand Down
7 changes: 6 additions & 1 deletion css/protip.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
line-height: 1;
opacity: 0;
pointer-events: none;
font-family: sans-serif;
Tofandel marked this conversation as resolved.
Show resolved Hide resolved
box-sizing: border-box;
transition: opacity 0.2s ease-out;
Tofandel marked this conversation as resolved.
Show resolved Hide resolved

> i {
position: absolute;
Expand All @@ -23,7 +25,7 @@
}
}

&-arrow {
&-arrow, &-arrow-border {
content: '';
display: block;
position: absolute;
Expand All @@ -32,6 +34,9 @@
border-style: solid;
border-color: transparent;
}
&-arrow-border {
z-index: -1;
}

&-show {
opacity: 1;
Expand Down
Loading