Rename placehoder "sheetsize_default" to <!-- %template_sheetsize% --> #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please consider my comment on the original issue, but generally I am all in favor of making placeholder syntax consistent and therefore, of amending the Readme (please do) and merging this PR. |
kvid
added a commit
that referenced
this pull request
Jun 11, 2024
kvid
added a commit
that referenced
this pull request
Jun 14, 2024
Fixes #377 (makes HTML output template placeholders more consistent)
kvid
added a commit
that referenced
this pull request
Jun 17, 2024
Fixes #377 (makes HTML output template placeholders more consistent)
Fixes #377 (makes HTML output template placeholders more consistent)
|
I see some recent force-pushes so I will wait for a final review request before merging :) |
formatc1702
approved these changes
Jun 25, 2024
kvid
added a commit
that referenced
this pull request
Jul 5, 2024
Fixes #377 (makes HTML output template placeholders more consistent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@formatc1702 must must check if this suggested change (placeholder name consistency) is OK, or if it might have some bad side-effects. If there is a good reason to keep this one placeholder very different from the others, then that reason should be explained in a code comment.
A bonus advantage by using the name
<!-- %template_sheetsize% -->, is that it will be easy to later generalize by letting any string or numericmetadata.{item}.{key}entry replace the corresponding<!-- %{item}_{key}% -->placeholder.TODO: If both PR #371 and this PR is accepted, then the(it is now updated)templates/README.mdfile must be updated.Fixes #377