Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General clarification in syntax description and README #386

Closed
wants to merge 6 commits into from

Conversation

martinrieder
Copy link
Contributor

@martinrieder martinrieder commented Jun 14, 2024

Comparing DataClasses.py to the syntax.md, I noticed that image was missing a description of two attributes.

EDIT: Per the discussion below, I am not changing the image description to add missing attributes.
I am instead proposing some other clarification on the syntax description and alignment with README.

Copy link
Collaborator

@kvid kvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I cannot approve this PR.

docs/syntax.md Outdated Show resolved Hide resolved
docs/syntax.md Outdated Show resolved Hide resolved
@martinrieder martinrieder marked this pull request as draft June 20, 2024 13:19
@martinrieder martinrieder requested a review from kvid July 2, 2024 00:05
@martinrieder martinrieder changed the title Image syntax description missing scale and fixedsize. Update syntax description Jul 2, 2024
@martinrieder martinrieder marked this pull request as ready for review July 2, 2024 00:23
@martinrieder
Copy link
Contributor Author

martinrieder commented Jul 2, 2024

@kvid wrote:

I'm sorry, I cannot approve this PR.

I understood your concerns, so I reverted the proposed changes. (EDIT: fixed on 2024-Jul-06 by 8d8cc96)

Instead, I am proposing some other changes for general clarification of the syntax now.
Please review the 4 previous commits.

@martinrieder martinrieder changed the title Update syntax description General clarification in syntax description and README Jul 6, 2024
@martinrieder
Copy link
Contributor Author

@kvid it may have been a bad idea to recycle this PR to suggest other changes to the syntax description. Since the review still lists a requested change, it remains blocked for merging. Could you please review this again or do you want me to put the commits into a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants