Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional build output directory #51

Closed
wants to merge 3 commits into from

Conversation

wassfila
Copy link

This is a suggestion to enable the inputs.out definition as this action currently does not allow usage of the astro config outDir.
If outDir is different than './dist' then users can specify it in the out input.
I was hesitant to call it differently like outDir our out-dir to avoid any naming case convention conflict.
The only catch is that if path is specified, then out must necessarily also be specified, which is mentioned in the description

needed out path as it can be configured differently
document new input
@wassfila wassfila requested a review from natemoo-re April 21, 2024 08:35
@natemoo-re
Copy link
Member

I'm fairly certain that this would be covered by #29, but I'm not sure when I might get a chance to finish that PR up.

Ideally, this action would be able to inherit the outDir option from the Astro config. I'm going to close this to avoid adding a new option to the current action, but this is definitely a very real pain point that should be fixed.

@natemoo-re natemoo-re closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants