Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Astro 5.5 blog #1429

Merged
merged 11 commits into from
Mar 13, 2025
Merged

Astro 5.5 blog #1429

merged 11 commits into from
Mar 13, 2025

Conversation

ascorbic
Copy link
Contributor

Browser Test Checklist

I have tested this PR on at least three of the following browsers:

  • Chrome / Chromium
  • Firefox
  • Android Firefox
  • Safari
  • iOS Safari

@netlify Netlify
Copy link

netlify bot commented Mar 11, 2025 •
edited
Loading

✅ Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit 5e86afa
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/67d2d2ff8981c00008afb348
😎 Deploy Preview https://deploy-preview-1429--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 5 paths audited
Performance: 96 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

sarah11918
sarah11918 reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fabulous Matt! Just some tiny thoughts!

ascorbic and others added 2 commits March 12, 2025 06:40
@ascorbic @sarah11918 @delucis
Apply suggestions from code review
d7d7b62 
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
@ascorbic
Add script order flag
9f3d915
sarah11918
sarah11918 reviewed Mar 12, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a suggestion of how the preserveScript section could look if you didn't want code examples! Take anything from it you like!

Nothing wrong with the original!

@ascorbic ascorbic marked this pull request as ready for review March 13, 2025 11:47
ematipico
ematipico approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ascorbic ascorbic merged commit b585659 into main Mar 13, 2025
6 checks passed
@ascorbic ascorbic deleted the feat/astro-550 branch March 13, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis left review comments

@HiDeoo HiDeoo HiDeoo left review comments

@sarah11918 sarah11918 sarah11918 left review comments

@ematipico ematipico ematipico approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ascorbic @delucis @HiDeoo @ematipico @sarah11918 @yanthomasdev