Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Biome config, lint script and lint CI job #1649

Closed
wants to merge 11 commits into from

Conversation

hippotastic
Copy link
Contributor

Description

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Mar 20, 2024 9:26pm
starlight-i18n 🔄 Building (Inspect) Visit Preview Mar 20, 2024 9:26pm

Copy link

changeset-bot bot commented Mar 20, 2024

⚠️ No Changeset found

Latest commit: 09ef454

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hippotastic
Copy link
Contributor Author

hippotastic commented Mar 20, 2024

Here are the differences I noticed vs ESLint:

Pros:

  • Simpler to configure
  • Much faster
  • The error messages generated by the CLI are awesome, include relevant code snippets and provide actionable recommendations

Cons:

  • There seems to be no equivalent for the no-floating-promises ESLint rule yet
  • The CLI output doesn't seem to be picked up by GitHub's problem matcher

@liruifengv
Copy link
Member

Therel has a biome GitHub Action setup, I don't know if it works.
https://biomejs.dev/recipes/continuous-integration/

@hippotastic
Copy link
Contributor Author

Closed for now after internal discussion, we'll start with ESLint and revisit a migration to Biome once the cons have been fixed in Biome. We love it though, really fast and promising!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Changes to GitHub Action workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants