Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes display of long site title on mobile #2722

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

techfg
Copy link
Contributor

@techfg techfg commented Dec 17, 2024

Description

Splash

  • Before
    image
  • After
    image

Doc

  • Before
    image
  • After
    image

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: f7e0d6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit f7e0d6a
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6781887cb078e100088c5eae
😎 Deploy Preview https://deploy-preview-2722--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 17, 2024
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience waiting for a review @techfg! At first, I wasn’t able to reproduce the issue, but I did see it in Edge, so it seems to be browser specific and this change does look like it fixes things. Thanks again 🙌

@delucis delucis added the 🌟 patch Change that triggers a patch release label Jan 10, 2025
@delucis delucis merged commit 0b206d3 into withastro:main Jan 10, 2025
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 10, 2025
@techfg
Copy link
Contributor Author

techfg commented Jan 10, 2025

Thanks for reviewing @delucis! Strange, I was able to reproduce in edge/chrome/firefox running on Windows but glad to hear that you were able to repro and confirm!

@delucis
Copy link
Member

delucis commented Jan 10, 2025

Yeah may also depend on OS? On macOS, Firefox and Safari were behaving as expected for me, but Edge wasn’t. The web is fun! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

site title/logo extends beyond menu toggle and search button not visible on mobile view
2 participants