Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum supported Astro version to 5.1 #2736

Merged
merged 13 commits into from
Jan 10, 2025
Merged

Update minimum supported Astro version to 5.1 #2736

merged 13 commits into from
Jan 10, 2025

Conversation

delucis
Copy link
Member

@delucis delucis commented Dec 20, 2024

Description

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 6b54a4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package 🌟 markdoc Changes to Starlight’s Markdoc package labels Dec 20, 2024
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 6b54a4a
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67818ff337bfa90008511997
😎 Deploy Preview https://deploy-preview-2736--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@delucis delucis changed the title Chris/astro-5.1 Update minimum supported Astro version to 5.1 Dec 20, 2024
@delucis delucis added the 🌟 minor Change that triggers a minor release label Dec 20, 2024
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Dec 20, 2024

size-limit report 📦

Path Size
/index.html 6.89 KB (-1.54% 🔽)
/_astro/*.js 21.19 KB (0%)
/_astro/*.css 13.75 KB (0%)

@HiDeoo
Copy link
Member

HiDeoo commented Dec 20, 2024

Small note that the dev version can not be updated until withastro/astro#12652 is fixed.

@delucis
Copy link
Member Author

delucis commented Dec 20, 2024

Small note that the dev version can not be updated until withastro/astro#12652 is fixed.

Ohhhh, you even said that already in #2612 (comment)

Damn, that makes this really tricky. We can’t really have a dev version lower than our minimum supported version I don’t think?

@delucis delucis added this to the v0.31 milestone Jan 9, 2025
@lilnasy
Copy link
Contributor

lilnasy commented Jan 9, 2025

Small note that the dev version can not be updated until withastro/astro#12652 is fixed.

It can if you manually set process.env.NODE_ENV to development before running the failing test. It corrects astro's wrong guess that the environment is production, and it correctly looks for the development data store instead of the production one.

@ascorbic
Copy link

ascorbic commented Jan 9, 2025

@lilnasy
Copy link
Contributor

lilnasy commented Jan 9, 2025

This is what we do in the Astro tests:

The default of data store retrieval is to assume production, so wouldn't implementing the linked workaround this arrive at the same failure?

I imagine the variable would need to be definitely set to development, not just deleted, which is what worked for me.

@delucis
Copy link
Member Author

delucis commented Jan 9, 2025

I imagine the variable would need to be definitely set to development, not just deleted, which is what worked for me.

Not sure exactly why, but it does look like deleting it fixes our E2E tests in this context.

@lilnasy
Copy link
Contributor

lilnasy commented Jan 9, 2025

Right, of course, vite sets it to development if its not already defined, same as it does normally when invoked rom the cli.

@ascorbic
Copy link

ascorbic commented Jan 9, 2025

I have a PR which should fix this. It's doing a preview build if you'd like to check.

@ascorbic
Copy link

ascorbic commented Jan 9, 2025

Install astro@experimental--data-store-location

@delucis
Copy link
Member Author

delucis commented Jan 9, 2025

Thanks @ascorbic! The experimental release does seem to fix things. You can see end-to-end tests running successfully in a branch off this PR here: #2776

@delucis delucis merged commit 29a885b into main Jan 10, 2025
16 checks passed
@delucis delucis deleted the chris/astro-5.1 branch January 10, 2025 21:28
@astrobot-houston astrobot-houston mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 markdoc Changes to Starlight’s Markdoc package 🌟 minor Change that triggers a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants