-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum supported Astro version to 5.1 #2736
Conversation
🦋 Changeset detectedLatest commit: 6b54a4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
Small note that the dev version can not be updated until withastro/astro#12652 is fixed. |
Ohhhh, you even said that already in #2612 (comment) Damn, that makes this really tricky. We can’t really have a dev version lower than our minimum supported version I don’t think? |
It can if you manually set process.env.NODE_ENV to development before running the failing test. It corrects astro's wrong guess that the environment is production, and it correctly looks for the development data store instead of the production one. |
This is what we do in the Astro tests: |
The default of data store retrieval is to assume production, so wouldn't implementing the linked workaround this arrive at the same failure? I imagine the variable would need to be definitely set to development, not just deleted, which is what worked for me. |
Not sure exactly why, but it does look like deleting it fixes our E2E tests in this context. |
Right, of course, vite sets it to development if its not already defined, same as it does normally when invoked rom the cli. |
I have a PR which should fix this. It's doing a preview build if you'd like to check. |
Install |
Description