Make reward duration configurable in RequestMint script - #47
Merged
Conversation
Replace hardcoded 30-day reward duration with optional REWARD_DURATION_DAYS environment variable. The script defaults to the contract's REWARD_DURATION value when the env var is not set. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Coverage after merging rsolari/configurable-reward-duration into main will be
Coverage Report
|
|||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace hardcoded 30-day reward duration with optional
REWARD_DURATION_DAYSenvironment variable. The script defaults to the contract's REWARD_DURATION value when the env var is not set, maintaining backward compatibility while allowing configuration.Changes
REWARD_DURATION_DAYSenv variable support toRequestMint.ts.env.templatewith documentation for the new configuration optionTest plan
REWARD_DURATION_DAYSset to verify it uses contract valueREWARD_DURATION_DAYSset to verify it uses the override value🤖 Generated with Claude Code